garrysmod
garrysmod copied to clipboard
Utilize The close method in various places and add removeing option
Please mark PR as draft, so many commits, no way to tell you are done. Also learn git, you are force pushing commits which is usually a bad habit, especially in contributing
If you are not good at git CLI, use GitHub Desktop or Sublime Merge (or any other GUI-based git client)
@GitSparTV
- How should I mark this PR as draft ?
- Already learned it. I am force-pushing because it is needed. As Gmod has CR-LF endings somebody has committed LF only. This messed up my sending for committing proper CR-LF to the Gmod repo. I am not using Git CLI. I use git from console.
I can make new PR if you like.
You can mark it as draft on this page, somewhere at the top or in ...
menu.
Also, the name of this PR is confusing and is not related to commits
- Obviously cannot find it. Did I do something wrong ?
- I can change the name via github, but I doubt that the Gmod devs will want
LF
endings instead ofCRLF
. when I useCRLF
as Gmod devs expect me to it marks the whole file as changed, so I am confused which one is required ?
@GitSparTV
My modification is already done. I moved it here as I tough it would be less messy. I see other files using CRLF
and I wonder if this file has to be converted from LF
to CRLF
like the others vgui/*.lua
elements. If I do that it will be marked as total rewrite.
Gmod devs require CRLF
though and I doubt that I will be able to make it without diffing the whole file. It was LF
to begin with.
Hello, @Rubat, @GitSparTV
I do not intend to add anything else to this, so you are welcome to merge it when needed.
removeing