garrysmod icon indicating copy to clipboard operation
garrysmod copied to clipboard

Utilize The close method in various places and add removeing option

Open dvdvideo1234 opened this issue 2 years ago • 7 comments

dvdvideo1234 avatar Oct 19 '21 18:10 dvdvideo1234

Please mark PR as draft, so many commits, no way to tell you are done. Also learn git, you are force pushing commits which is usually a bad habit, especially in contributing

GitSparTV avatar Oct 19 '21 19:10 GitSparTV

If you are not good at git CLI, use GitHub Desktop or Sublime Merge (or any other GUI-based git client)

GitSparTV avatar Oct 19 '21 19:10 GitSparTV

@GitSparTV

  1. How should I mark this PR as draft ?
  2. Already learned it. I am force-pushing because it is needed. As Gmod has CR-LF endings somebody has committed LF only. This messed up my sending for committing proper CR-LF to the Gmod repo. I am not using Git CLI. I use git from console.

I can make new PR if you like.

dvdvideo1234 avatar Oct 19 '21 19:10 dvdvideo1234

You can mark it as draft on this page, somewhere at the top or in ... menu.

Also, the name of this PR is confusing and is not related to commits

GitSparTV avatar Oct 19 '21 19:10 GitSparTV

  1. Obviously cannot find it. Did I do something wrong ? image
  2. I can change the name via github, but I doubt that the Gmod devs will want LF endings instead of CRLF. when I use CRLF as Gmod devs expect me to it marks the whole file as changed, so I am confused which one is required ?

dvdvideo1234 avatar Oct 19 '21 19:10 dvdvideo1234

@GitSparTV

My modification is already done. I moved it here as I tough it would be less messy. I see other files using CRLF and I wonder if this file has to be converted from LF to CRLF like the others vgui/*.lua elements. If I do that it will be marked as total rewrite.

Gmod devs require CRLF though and I doubt that I will be able to make it without diffing the whole file. It was LF to begin with.

dvdvideo1234 avatar Oct 19 '21 19:10 dvdvideo1234

Hello, @Rubat, @GitSparTV

I do not intend to add anything else to this, so you are welcome to merge it when needed.

dvdvideo1234 avatar Oct 31 '21 09:10 dvdvideo1234

removeing

Aws0mee avatar Sep 11 '23 03:09 Aws0mee