Asad Jeewa
### Please describe what needs to be maintained. step.py has too many components, some of which are independent i.e. `Step` and `TrainerStep` both extend `Component` ### Describe the outcome you'd...
### Please describe what needs to be maintained The Guardrails PR https://github.com/instadeepai/Mava/pull/596 highlighted some non-breaking issues that we should revisit.  - `Step` and `EpochUpdate` are both dependent on each...
### Please describe what needs to be maintained? extras_specs is emebeded in builder.store.ma_environment_spec but there also exists a separate builder.store.extras_spec.extra specs ### Describe the outcome you'd like remove redundant store...
## What? Fix partial import BaseTrainerInit in required_copmponets() method of various components Closes https://github.com/instadeepai/Mava/issues/682 ## Why? `step_test.py` was failing:` ImportError: cannot import name 'BaseTrainerInit' from partially initialized module 'mava.components.jax.training.trainer' (most...
### Describe the bug Cannot import BaseTrainerInit in required_components method ImportError: cannot import name 'BaseTrainerInit' from partially initialized module 'mava.components.jax.training.trainer' (most likely due to a circular import) (/home/asad/Github/mava/mava/components/jax/training/trainer.py ### To...
[INVESTIGATION] MADDPG/MAD4PG are slower than MAPPO in certain instances (pixel-based environments?)
### What do you want to investigate? MADDPG/ MAD4PG are both significantly slower than MAPPO in certain instances. 1. Run MADDPG on Coop pong/ PCB Grid for n steps with...
### What do you want to investigate? Updating DDPG with only the critic network yields better performance. For this to be carried out, we need to update the DDPG actor...
[BUG] get_agent_type assumes naming convention that is not consistent across all of our environments
### Describe the bug https://github.com/instadeepai/Mava/blob/develop/mava/specs.py#L68 assumes that agents from all environments are named with the convention `type_identifier` and hence using `split` to extract type. This is in some environments such...
### Please describe what needs to be maintained? Rename train_loop_fn to exec_loop_fn since this is line line with its purpose ### Describe the outcome you'd like Variable name reflects purpose...
### Describe the bug Jax example runs but gives slow compilation warnings: `[trainer/0] [Compiling module jit_sgd_step.8] Very slow compile? If you want to file a bug, run with envvar XLA_FLAGS=--xla_dump_to=/tmp/foo...