Mava
Mava copied to clipboard
Bugfix/partial dependency imports
What?
Fix partial import BaseTrainerInit in required_copmponets() method of various components Closes https://github.com/instadeepai/Mava/issues/682
Why?
step_test.py
was failing: ImportError: cannot import name 'BaseTrainerInit' from partially initialized module 'mava.components.jax.training.trainer' (most likely due to a circular import) (mava/components/jax/training/trainer.py
How?
Import BaseTrainerInit from training init.py to avoid partial dependency
Extras
Added determinism and rounding to avoid test_step()
failing sometimes
Decoupling of step and model_updating classes needed https://github.com/instadeepai/Mava/issues/679 in future