Mava icon indicating copy to clipboard operation
Mava copied to clipboard

[MAINTAIN] Investigate circular and isloated dependencies in MAVA Redesign

Open AsadJeewa opened this issue 1 year ago • 0 comments

Please describe what needs to be maintained

The Guardrails PR https://github.com/instadeepai/Mava/pull/596 highlighted some non-breaking issues that we should revisit. 180448888-344909c9-53fb-4f86-8df3-291f0723da39

  • Step and EpochUpdate are both dependent on each other
  • ParallelSequqnceAdder, ExtraLogProbSpec and ExecutorInit are isolated

Describe the outcome you'd like

All isolated nodes should be pruned (such as ExecutorInit) or explained by inheritance (ParallelSequqnceAdder) or Optionality (ExecutorInit)

How do we know when maintenance is complete?

Checklist:

  • [ ] Refactor PR merged into dev with MAPPO system still running as before

AsadJeewa avatar Aug 11 '22 09:08 AsadJeewa