Anna Shaleva
Anna Shaleva
Everything is almost done, so once finished, please, format commits according to https://github.com/nspcc-dev/.github/blob/master/git.md#commits and add a proper signoff to the commit messages.
Wow, a really unexpected bug! Sure, it should be aligned with C# implementation. They use an ordered dictionary for the internal Map item implementation, so the bug is legit. https://github.com/neo-project/neo/blob/3f2f78c1fcf71ea51f2c40c3a0e67062ac390aed/src/Neo.VM/JumpTable/JumpTable.Compound.cs#L45...
Vote up for cache usage instead of storage scheme change. > That's solve the node issue, but it won't solve external readers like rpc storage. Could you explain, why? Because...
> What I've not seen is any benefit to the kind of modularization we have. We're wasting time and effort for nothing, I think. So I'd vote for repo and...
I've checked the current master (`b05501af882a0d1f2a1a7841c6ddc4d0504e5fc1`), the genesis application log for `OnPersist` trigger contains required Deploy notifications for all 9 contracts, so it works as expected. It also contains required...
So this issue can be closed as completed.
> I agree with @AnnaShaleva @vang1ong7ang, do you think we need to stop the node *explicitly* in case of negative reference counter?
> do you think we need to stop the node explicitly in case of negative reference counter? OK, I see, Jimmy has created another PR for that.
@roman-khimov, we may want to include https://github.com/neo-project/neo/issues/3210 into this version.
@roman-khimov, should we include #2944 into 3.7.0?