Anna Shaleva
Anna Shaleva
We can implement it, but just a note: this change was not merged into neo-project master.
Depends on https://github.com/nspcc-dev/neo-go/pull/3554.
@shargon, good, that is the last thing that is missing from #3210, thus I think you may adjust your PR message and say that this PR closes #3210. We have...
> Does it cover all types of events and notifications It does. > Perhaps some UTs are necessary. But the thing is that we just don't have a use-case for...
> It's done in neo-go? i can't find it Take a look at https://github.com/nspcc-dev/neo-go/blob/79e78980c4679e8929ceb509ed56359c5b017279/pkg/services/rpcsrv/server.go#L1001, we take signer's witness, infer invocation script (if needed) and don't change verification script. And hence,...
Don't forget to update `neo-go db restore` command, ref. https://github.com/nspcc-dev/neo-go/pull/3974#discussion_r2270114011, the list of block versions is extended.
Still a couple of TODOs left, will finish them. @roman-khimov, let's perform some initial review.
@roman-khimov, I think we need some third opinion on these topics.
> How about System.Runtime.LoadScript calls It leads to new execution context creation, thus it's a valid part of invocation tree. But is this information useful in practice? Dynamic invocations are...
@ixje sorry for the delay. Actually, when we don't need https://github.com/nspcc-dev/neo-go/pull/3569#discussion_r1872155940 and https://github.com/nspcc-dev/neo-go/pull/3569#discussion_r1872184630 to be fixed, there are only a couple of non-critical issues left to be fixed, so the...