neo icon indicating copy to clipboard operation
neo copied to clipboard

Perform native contract initialization for the set of hardforks

Open shargon opened this issue 1 year ago • 4 comments

Close https://github.com/neo-project/neo/issues/3200

shargon avatar Apr 23 '24 10:04 shargon

Something has happened with the Neo unit-tests, they are hanging (checked this locally, the result is the same):

  Neo.GUI -> /home/anna/Documents/GitProjects/neo-project/neo/src/Neo.GUI/bin/Debug/net8.0-windows/Neo.GUI.dll
  Neo.UnitTests -> /home/anna/Documents/GitProjects/neo-project/neo/tests/Neo.UnitTests/bin/Debug/net8.0/Neo.UnitTests.dll
Test run for /home/anna/Documents/GitProjects/neo-project/neo/tests/Neo.UnitTests/bin/Debug/net8.0/Neo.UnitTests.dll (.NETCoreApp,Version=v8.0)
Microsoft (R) Test Execution Command Line Tool Version 17.9.0 (x64)
Copyright (c) Microsoft Corporation.  All rights reserved.

Starting test execution, please wait...
A total of 1 test files matched the specified pattern.

AnnaShaleva avatar Apr 25 '24 18:04 AnnaShaleva

Something has happened with the Neo unit-tests, they are hanging (checked this locally, the result is the same):

  Neo.GUI -> /home/anna/Documents/GitProjects/neo-project/neo/src/Neo.GUI/bin/Debug/net8.0-windows/Neo.GUI.dll
  Neo.UnitTests -> /home/anna/Documents/GitProjects/neo-project/neo/tests/Neo.UnitTests/bin/Debug/net8.0/Neo.UnitTests.dll
Test run for /home/anna/Documents/GitProjects/neo-project/neo/tests/Neo.UnitTests/bin/Debug/net8.0/Neo.UnitTests.dll (.NETCoreApp,Version=v8.0)
Microsoft (R) Test Execution Command Line Tool Version 17.9.0 (x64)
Copyright (c) Microsoft Corporation.  All rights reserved.

Starting test execution, please wait...
A total of 1 test files matched the specified pattern.

looks like Neo receive all the hardforks, but it need null :S

shargon avatar Apr 26 '24 07:04 shargon

@shargon @AnnaShaleva is it just for this PR? The test handing issue.

cschuchardt88 avatar Apr 26 '24 07:04 cschuchardt88

@shargon @AnnaShaleva is it just for this PR? The test handing issue.

yes, but it's because without null, neo contract is not initialized in out tests

shargon avatar Apr 26 '24 11:04 shargon

@shargon, I've fixed the test, please, see the last commit. Now all tests are passing and the logic works as expected. Let's review this PR one more time (if needed) and merge, we need to include it into 3.7.

AnnaShaleva avatar May 06 '24 20:05 AnnaShaleva

I will test here as well.

vncoelho avatar May 06 '24 20:05 vncoelho