Ranbir Singh

Results 29 comments of Ranbir Singh

> Can anybody can tell me how you all have calculated the stats of pokemon. Can anybody can share the formula? Here is link for for that :https://github.com/skydoves/Pokedex/blob/main/app/src/main/java/com/skydoves/pokedex/model/PokemonInfo.kt Also always...

if I may I would like to suggest you please remove "GlobalScope.launch(Dispatchers. Main)" and replace it with lifecycle aware coroutine scope, calling GlobalScope inside the adapter will launch a top-level...

Hi @anikiki I have created issues for memory leak https://github.com/duckduckgo/Android/issues/1990 This is the report from "TabSwitcherActivity", I have attached a screenshot for your reference, only "Favicon" is retaining 1.5 Mb...

in my opinion there is no need to optimize this screen with coroutines, The main reason behind the slow performance is the Memory leak. I was testing the app the...

> I will take a look (right now I'm afk). > > Just to set expectations: > > * when the fire button is highlighted, the url bar should be...

if I am not wrong before someone added this scrolling url bar, to fix that bottom-anchored content , even duckduckgo also used pinned URL bar

Here is that conversation, please read this. if we still want that scrolling effect we can work on that also. :https://github.com/duckduckgo/Android/pull/674

If you can test once I don't think they ever hide that. I have built a browser from scratch, in my opinion hiding the URL bar is not a very...

Hi @cmonfortep ! please review this PR (bottom-anchored content and canvas drawing fixed). Let me know your thoughts

> @AndroidPoet I see we still have the toolbar pinned to the top. As I commented, expected behavior is to mimic what chrome or similar browser do. > > Here's...