Pokedex
Pokedex copied to clipboard
Add to F-Droid
Hey, I noticed that this app is licensed by a free license and I'd like to see this app in the F-Droid cataolgue, a store of FOSS Android apps. Take a look to the request here
@skydoves could you please fix this?
Hey @airon90, Sorry for the late reply.
As following the comments, F-Droid can't recognize metadata that is located in the dependencies.gradle
file right?
Then should I modify all of the references of the dependencies.gradle
to statically or can we deal with it just by modifying the versionCode
and versionName
?
F-Droid maintainer here. Thanks for chiming in, @skydoves! We'd need metadata (app description, summary, screenshots etc) in a Fastlane structure β and versionCode
plus versionName
as literals (not variables or function calls) in build.gradle
(which is also important to automatically detect new versions).
Hi @IzzySoft, thanks for the review. I just created a PR (#44) for integrating into the F-Droid, so could you please check the structure of the metadata is correct?
versionName getVersionName()
won't work. versionName
and versionCode
(already is) must be literals β no variables or function calls, see above. Else updates won't be found (the F-Droid updater just uses RegEx to parse the gradle files, it doesn't execute them) and you'd need to create a merge request at fdroiddata vor each version, which is not a good idea :wink:
Fastlane structure looks good β but short_description.txt
is too long. It will be truncated at 80 chars.
You might wish to place an icon.png
into metadata/en-US/images
(not mandatory, but helpful β especially in case your app uses only XML icons).
Hi @yehezkiell, I updated the metadata from your reviews! Could you please check about it again?
Can anybody can tell me how you all have calculated the stats of pokemon. Can anybody can share the formula?
Can anybody can tell me how you all have calculated the stats of pokemon. Can anybody can share the formula?
Here is link for for that :https://github.com/skydoves/Pokedex/blob/main/app/src/main/java/com/skydoves/pokedex/model/PokemonInfo.kt Also always create new issue or add a commnet in related open issue
What about the issue? @skydoves @IzzySoft
Sorry @airon90 β I'm usually not working in the "games segment". I've just carried over the issues I saw reported at F-Droid so they can be addressed. The request there will be worked on by another team member.
@skydoves Do you have updates?
@inson1 see my comment just before yours: I don't work on games, so no need to ping me for updates on their progress :wink:
@IzzySoft sorry :)
Huh? Eh, err⦠Sorry, too // as it wasn't you :see_no_evil:
(I simply unsubscribe from notifications here then :wink:)