Alex Waygood

Results 902 comments of Alex Waygood

I'm afraid I'm not a maintainer, so I don't have the power to run the CI. I'm just a triager and contributor :)

> I seem to have hit a wall here with the `run_primer`; the action seems to run 4 times and fail twice, and at this stage I don't know what...

> the above code could be simplified to `from typing_extensions import TypeAlias`. Some packages might prefer to only require the extra dependency if a user is installing the package on...

@gamecss, please don't post duplicate comments in multiple places. Copying and pasting the reply I left you in #16903: > Correct. You need to do this: > > ```py >...

It looks like this check is triggering some hits in `.pyi` files. Maybe partially-defined checks should all be skipped for stub files, since they're never actually executed at runtime?

It looks like `sympy` has [a lot of code along the lines of](https://github.com/sympy/sympy/blob/ba5b3310bffc45c24efb6f474fd76693613544fc/sympy/core/kind.py#L314-L321): ```python for i in range(2): if i == 0: foo = 1 else: bar = foo ```...

> Potentially, we can call the example you listed as partially-defined and accept that it will have a higher false-positive rate. That way use-before-def will have a lower false-positive rate...

> I didn't see any other issues that were exactly this issue. Sort of a duplicate of #12186, but you've put forward a better reason for fixing the bug than...

Sounds like ~https://github.com/caronc/apprise~ might have caught https://github.com/python/mypy/issues/13536

You can cross off flake8-pyi from the list at the top (added in https://github.com/hauntsaninja/mypy_primer/commit/893b19fb142b0953f9bf7be766e685de47e55217 :)