Alex Waygood

Results 902 comments of Alex Waygood

`contextlib.contextmanager` takes a callable and returns another callable that is in no way distinguished from most other callables. This makes it pretty easy to type: https://github.com/python/typeshed/blob/c51de8ee6859b3b1b411d48e56cd537716893e81/stdlib/contextlib.pyi#L76 `functools.lru_cache` and `functools.cache`, on...

Primer analysis: - `ibis` is just an error message changing slightly - `werkzeug` would just need to change their annotations on their subclass to match our new annotation for `discard()`...

> This has conflicts now. I fixed the merge conflicts, but it's still not clear to me whether we want to fix the inconsistency between the different methods by making...

This PR is unfortunately still unmergeable for now, due to the `pre-commit.ci` failures: there are errors in the Ruff and flake8-pyi checks. The Ruff errors seem to be an obvious...

> I'm fine with noqa'ing the warnings in the `CoersiveEnum`s. Maybe even do so for the whole file. Good point, we could easily add an entry to `per-file-ignores` in our...

> cc @AlexWaygood since you added the "DO NOT MERGE" label. I added that ages ago because Eric's PR description seemed to indicate that that was what he wanted (the...

> CC @AlexWaygood in case you see any issue with my proposal, but it seems sound to me and my quick testing (I'm super busy this week unfortunately, so probably...

> I wasn't sure if that meant I should put all the things I added here in a `grpcio` folder or if there was another mechanism, but it sounds like...

> Motivation was originally related to #3968 Thanks so much for this series of PRs, by the way, I'm a big fan! Great to see all this stuff being cleaned...

> If I remember correctly, the METADATA files are mainly included for reference or potential use by tooling and have no runtime impact apart from that. I believe this is...