Alex Waygood

Results 902 comments of Alex Waygood

Interesting. I can reproduce this. For reference argument 8 of `builtins.open` is this: https://github.com/python/typeshed/blob/9b63a49f6419bc7a04cf0d2be0433c255f1b1852/stdlib/builtins.pyi#L1500 And the `_Opener` type alias is defined in `builtins.pyi` here: https://github.com/python/typeshed/blob/9b63a49f6419bc7a04cf0d2be0433c255f1b1852/stdlib/builtins.pyi#L1488 I suspect that this issue...

This bisects to https://github.com/python/mypy/commit/6442b02400ac6e6715247d29ea2d3da8ca8e35d8: I can reproduce with https://github.com/python/mypy/commit/6442b02400ac6e6715247d29ea2d3da8ca8e35d8 checked out locally, but not with https://github.com/python/mypy/commit/0665ce924290dad3f30010b3bb93310a71c8db81.

@JelleZijlstra or @hauntsaninja, could one of you transfer this issue to mypy? I think the best thing to do would be to revert https://github.com/python/mypy/commit/6442b02400ac6e6715247d29ea2d3da8ca8e35d8. It fixes the crash that it...

Cc. @Michael0x2a as author of the commit that this bisects to

I can't merge this PR because I'm not a maintainer

The underlying problem is the same as #8823: mypy reports that `type: ignore` comments are "unused" if they appear in code blocks that it detects are unreachable. (To an extent,...

> The off by one error is funny 🤣 You need to update the title of the PR as well ;)

> One question from my side. [Here](https://github.com/python/mypy/pull/14246#discussion_r1038989681) I asked you if you know the sphinx link to type for the docs. Any idea? This does not seem to render properly....

> Follow up question then. There is one more place in the docs where this needs fixing. Should I do it in this PR and a separate commit? A different...

The error message in CI says that black wants you to apply the following diff: ```diff --- mypy/messages.py 2023-01-23 13:51:23.667146 +0000 +++ mypy/messages.py 2023-01-23 13:52:16.792518 +0000 @@ -1700,13 +1700,11 @@...