Alex Waygood

Results 902 comments of Alex Waygood

Interestingly, I can only reproduce on mypy `master`, not with mypy 1.4.1. Can you reproduce with mypy 1.4.1 as well?

Anyway, here's a smaller repro that crashes with the same traceback on the `master` branch: ```py from dataclasses import dataclass from typing import Protocol, Tuple @dataclass class WithValidityPeriod(Protocol): ... periods:...

I bisected to find the source of the crash: ``` 6f2bfff521e708f015af1eec5118db4600b829be is the first bad commit commit 6f2bfff521e708f015af1eec5118db4600b829be Author: Ilya Priven Date: Sat Jun 17 09:02:36 2023 -0400 Add signature...

> > Interestingly, I can only reproduce on mypy master, not with mypy 1.4.1. Can you reproduce with mypy 1.4.1 as well? > > We had multiple issues so it's...

> Looks like typeshed syncing is having a conflict when cherry picking "Remove use of LiteralString in builtins" ([6f913a148](https://github.com/python/mypy/commit/6f913a148e1c1ec126d2009272a4a26ff61b8195)) https://github.com/python/mypy/actions/workflows/sync_typeshed.yml Here you go: - #15590 I'm pretty seasoned with these...

> Did we remove typeshed for `attr` or something like that? (`attrs` hasn't had stubs in typeshed for quite a while; they're a `py.typed` package and bundle their own stubs...

This PR fixes a new stubtest false positive that would be somewhat annoying for typeshed -- would be great to get it (or an alternative fix) in for v1.5: -...

> This PR fixes a new stubtest false positive that would be somewhat annoying for typeshed -- would be great to get it (or an alternative fix) in for v1.5:...

It would be great if we could cherry-pick https://github.com/python/typeshed/commit/f577c4c133ae6bb57cade534179b41ef04b5731f onto the 1.5 release branch, so that mypy users will be able to use the latest typing_extensions features -- `typing_extensions 4.7.0`...

> It would be great if we could cherry-pick [python/typeshed@f577c4c](https://github.com/python/typeshed/commit/f577c4c133ae6bb57cade534179b41ef04b5731f) onto the 1.5 release branch, so that mypy users will be able to use the latest typing_extensions features -- `typing_extensions...