Alex Vulaj

Results 42 comments of Alex Vulaj

Sorry for taking a while to get back to this - other repositories have been having issues as well that required more of our time. @davidnewhall it looks like this...

This looks like a pretty solid addition, thanks for the contribution!

/approve Looks alright to me but I'd like one other set of eyes

I rebased my PR today - not sure I understand the error in the PR Verify check but if anyone can point out what I need to do it'd be...

Hey @bluceshen , a few points. 1. Would you mind giving a brief explanation of what this PR does? 2. Could you convert your comments to English to stay consistent...

Hey @jwafle - I think this would be a wonderful thing to add to the library. You have my support to go ahead with a PR for this.

Is there any way we could add this as a new property instead? I'd prefer to not introduce a breaking change if we can avoid it here.

Hey @tebuka , we just cut a new release `v1.5.3` which reverts back to https://github.com/gorilla/websocket/commit/931041c5ee6de24fe9cba1aa16f1a0b910284d6d . We'll be stepping through the rest of the commits and trying to reapply in...