handlers icon indicating copy to clipboard operation
handlers copied to clipboard

[FEATURE] OpenTelemetry Instrumentation

Open jwafle opened this issue 1 year ago • 2 comments

Is there an existing feature request for this?

  • [X] I have searched the existing feature requests

Is your feature request related to a problem? Please describe.

OpenTelemetry is becoming a popular open-source solution for monitoring application performance. Well-defined semantic conventions are supplied for HTTP metrics and traces. See here: https://opentelemetry.io/docs/specs/semconv/http/

In following with their guidance on instrumentation, they recommend implementing instrumentation code in the library for which it is written: https://github.com/open-telemetry/opentelemetry-go-contrib/tree/main/instrumentation#new-instrumentation

Describe the solution that you would like.

If interested, I would be willing to contribute instrumentation code that implements OpenTelemetry metrics and tracing as a middleware for mux. Please let me know if you would like me to proceed with opening a PR.

Describe alternatives you have considered.

I have opened an issue to explore updating the current otelmux instrumentation: https://github.com/open-telemetry/opentelemetry-go-contrib/issues/5936

However, current guidance from OpenTelemetry is to seek to include instrumentation with the libraries/packages themselves, thus why I am opening this issue.

Anything else?

No response

jwafle avatar Jul 22 '24 19:07 jwafle

Hey @jwafle - I think this would be a wonderful thing to add to the library. You have my support to go ahead with a PR for this.

AlexVulaj avatar Aug 04 '24 23:08 AlexVulaj

Hey @jwafle - I think this would be a wonderful thing to add to the library. You have my support to go ahead with a PR for this.

Great! I'll work on opening a PR!

jwafle avatar Aug 15 '24 03:08 jwafle