Alex Vulaj
Alex Vulaj
@tomerb-neosec it looks like there are merge conflicts in this PR. If you get those taken care of we can go forward with reviewing and getting this merged in. Thanks...
@jaitaiwan > Don't add anything and make it a requirement of implementing libraries to perform the RFC shutdown process. I'm inclined to go with this option unless there's a strong...
And of course... immediately as I posted this I realized my problem 😅 . Closing.
One quick question - I would've expected the previous line to be the one getting flagged, as that's the `err` assignment getting wiped out. Is that a potential bug?
This looks good to me. @GreenMarmot as you've been extremely helpful with these changes, do you see any further issues with this PR as it is? If not, I'd like...
The linter errors seem to be unrelated to me. Thanks for the contribution @GreenMarmot
Hey @bconn98 , thanks for bringing this up - it's a good suggestion. Would you mind opening up a pull request with what you had in mind and linking it...
I'm okay with this change, @coreydaley can you give a second look please?
Hey @GocaMaric , thanks for the contribution! I don't think we need to bother checking for/verifying errors here since these are just example tests and those errors won't ever get...
@coreydaley This looks good to me, though I'll defer to you for a merge since I know you were looking at it first. While I'm in favor of giving consumers...