Alex Li
Alex Li
As I concern, credentials doesn't do anything during the dry run. So it should not be checked.
Not sure if you're indicating a solution. When forks are submitting PRs, we might use dry-run for them. Since their repo is missing the credential, checks will failed immediately because...
I think #108563 has already done what this PR has done. And we have another test case issue with test timeout that need to be resolved. Also, @thkim1011 is on...
> 1. if you don't use dart format on your codebase If you don't, #103414 should also be considered as a breaking change. > 2. if we don't make this...
> I feel that any sort of post processing on the generated files don't really belong in the `LocalizationsGenerator` class IMO it belongs to the generator, something like who generates...
I don't see any tests that verified if generated files are well-formatted.
Discussed with the author offline and he'll be back to maintain soon.
Previously we have #45972, but now the inspection is more broken.
> I don't think this is affecting a lot of users. @srawlins The inspection might be, but other linter rules applying to the method cannot take effect. For example, `avoid_redundant_argument_values`...
I would like to raise a concern about using `default` in the above examples. Methods like `forwardToF3` do return `f3` directly so it's reasonable since they have a reference connection...