actions-flutter-pub-publisher icon indicating copy to clipboard operation
actions-flutter-pub-publisher copied to clipboard

Not to check credentials when dry run only

Open AlexV525 opened this issue 2 years ago • 4 comments

When we run dry run on forks, it always checks credentials on the forked repo, which causes checks to fail since the forked repo typically does not have a secret of the pub.

It's better we bypass verify steps when users run dry run only.

AlexV525 avatar Feb 14 '22 04:02 AlexV525

Not really, what if someone want to run dry-run: true to check if the credentials are valid?

Better we create a new option like dry-run-bypass-credentials: true rather than modifying this current behavior.

alexrintt avatar May 09 '22 17:05 alexrintt

As I concern, credentials doesn't do anything during the dry run. So it should not be checked.

AlexV525 avatar May 09 '22 17:05 AlexV525

Oh I see now. In this case why not just create an empty repo var?

alexrintt avatar May 09 '22 18:05 alexrintt

Not sure if you're indicating a solution.

When forks are submitting PRs, we might use dry-run for them. Since their repo is missing the credential, checks will failed immediately because the credential check is placed at the first place.

AlexV525 avatar May 10 '22 03:05 AlexV525