Alberto Cabrera Pérez
Alberto Cabrera Pérez
Could you change the default constructor to set dimensions to `0`? I think its better to force the user to always specify their workgroup size.
You're right. I've removed your comment requesting the merge. Removing `const` from the attributes would require modifying all of our constexpr constructors and would reduce a bit of performance. We...
@AD2605 your PRs currently don't automatically trigger the CI. I will try to find a way for your PRs to be able to do so. In the meantime, ping any...
To be fair to ggerganov's question we could rework it to have `GGML_SYCL_DEBUG` prepend a prefix like `[SYCL]` to debug messages and print stuff through GGML_LOG_DEBUG. It is fine either...
I'll put a patch up that disables MMVQ for Q4_0 for now until I find out why this happens. Edit: My point here is, that I'm not reverting all this...
Added a reproducer. I am not sure what additional info could be provided, but I am happy to find more info if needed.
@pawan-nirpal-031 I've bisected the issue down to the `d6d1948c156810af89bf67ca637623c15a3bd098` commit (https://github.com/intel/llvm/pull/13894). The issue is not present in the `sycl` parent of the merge nor the `llvm-project` parent commit.
I was able to compile the source code that was giving me issues with today's nightly build (2024-07-08). I think this is solved. @pawan-nirpal-031 can you confirm everything is fine...
@tangjj11 Thanks for the contribution :+1: @intel/llvm-gatekeepers this is ready for merging
@ggerganov This is ready for review now. Thanks for your patience.