llvm icon indicating copy to clipboard operation
llvm copied to clipboard

[SYCL][COMPAT] Add default constructor for dim3

Open aacostadiaz opened this issue 1 year ago • 2 comments

This PR add a default constructor for the Dim3 class.

aacostadiaz avatar May 08 '24 17:05 aacostadiaz

Could you change the default constructor to set dimensions to 0? I think its better to force the user to always specify their workgroup size.

Alcpz avatar May 09 '24 09:05 Alcpz

You're right. I've removed your comment requesting the merge. Removing const from the attributes would require modifying all of our constexpr constructors and would reduce a bit of performance. We haven't encountered a case where we needed to modify the original dim3 object, so if there is no alternative, feel free to include the changes to the header that would make this work. This would include modifying the documentation and maybe creating a test

Alcpz avatar May 09 '24 21:05 Alcpz

Closing for now. Please re-open as/when required @aacostadiaz

joeatodd avatar Jun 05 '24 09:06 joeatodd