llvm icon indicating copy to clipboard operation
llvm copied to clipboard

[SYCL][COMPAT] Add experimental launch overloads accepting SG size

Open AD2605 opened this issue 1 year ago • 3 comments

add experimental launch overloads accepting SG size in SYCL

AD2605 avatar May 13 '24 11:05 AD2605

@joeatodd @Alcpz Let me know which functions require doxygen here. I compared it with launch.hpp and few have it while other's do not, hence did not document any, Or is it the readme you are talking about ?

AD2605 avatar May 14 '24 08:05 AD2605

@joeatodd @Alcpz Let me know which functions require doxygen here. I compared it with launch.hpp and few have it while other's do not, hence did not document any, Or is it the readme you are talking about ?

Just the README :+1:

joeatodd avatar May 14 '24 08:05 joeatodd

Just the README 👍

Done

AD2605 avatar May 14 '24 10:05 AD2605

@AD2605 your PRs currently don't automatically trigger the CI. I will try to find a way for your PRs to be able to do so. In the meantime, ping any of us (preferable @intel/syclcompat-lib-reviewers, which pings everyone) to trigger it for you.

Alcpz avatar May 15 '24 08:05 Alcpz

@intel/llvm-gatekeepers I believe this PR is ready to merge. The SYCL Pre Commit on Linux and SYCL Pre Commit on Windows pipelines (currently in progress) seem to failing everywhere at present, so I don't think this is a blocker.

joeatodd avatar May 15 '24 09:05 joeatodd