Johannes Terblanche

Results 299 comments of Johannes Terblanche

I'm going to leave this for now. I have some unfinished ideas on `compare` somewhere that will probably replace this.

What about making it a separate package? It will likely have higher level functionality in and having a separate package might be easier to maintain and test. Especially when it...

xref julia docs on return types: https://docs.julialang.org/en/v1/manual/functions/#Return-type-1

Is this getSummary and getSummaryGraph?

I would guess in `VariableNodeData`?

The same thing can maybe be done with the copy functions. We can perhaps use it to do the heavy lifting. ```julia _emptyDuplicate(dfg) = deepcopyGraph(typeof(dfg), dfg, []) ``` The line...

see #493 for some examples of how to do it.

It’s definitely a step in that direction. I think it’s going to be a continuous effort.

I think this revers to: https://github.com/JuliaRobotics/DistributedFactorGraphs.jl/blob/63a96cadd9182151da5fcd158ca23129caa9b7eb/src/services/Serialization.jl#L28 We currently only have the one PPE type.