Adam Gutglick
Adam Gutglick
We re-introduced one to build docs, I'll talk to @danking and we'll find a solution.
I think a flush is reasonable here, but maybe it should be handled within `VortexWriteOptions::write`? I think there are two issues with with "flush on drop": 1. Doing so with...
Seems like [ratatui](https://github.com/ratatui/ratatui) is a pretty good example, they use a tool called [cliff](https://git-cliff.org/) to generate their changelog and seems like release-plz accepts that. - Example release PR - https://github.com/ratatui/ratatui/pull/1671...
@aardappel I can give it a try, but do you have any log/reference to what broke in CI? I was looking around issues/PRs but couldn't find anything.
I couldn't find an error message there? but I've opened https://github.com/google/flatbuffers/pull/8700 that also tries to cleanup some of the other rust warnings.
I think this behavior is expected, it's explicitly called out in #16080.
There's also an issue (#16158) to change the default config, I'll take it.
For `ListingTable` as it is now - the only thing taken into account is the config value.
The test failure is a fuzzer failure, is there a accepted way to open tickets generated by fuzzing?
no opinion on that crate, but the better way to solve the core issue might be to implement a better `Drop`?