flatbuffers icon indicating copy to clipboard operation
flatbuffers copied to clipboard

Upgrade bitflags dependency in Rust implementation to version 2.6.0

Open gschulze opened this issue 1 year ago • 1 comments

The bitflags dependency in the Rust implementation has version 1.2.1, which is about five years old. When using flatbuffers with other crates that depend on a 2.x version of bitflags, this leads to duplicated dependencies. This could be avoided by updating the bitflags dependency to version 2.6.0.

gschulze avatar Aug 08 '24 18:08 gschulze

This will need to be reattempted, see: https://github.com/google/flatbuffers/pull/8411

aardappel avatar Sep 30 '24 16:09 aardappel

Any updates? This is the same for the num_enum dependency. Using the same 24.12.23 version for flatbuffer and flexbuffer, they result in duplicate dependency because of this, which is weird.

XinyuZeng avatar Dec 27 '24 02:12 XinyuZeng

This issue is stale because it has been open 6 months with no activity. Please comment or label not-stale, or this will be closed in 14 days.

github-actions[bot] avatar Jun 27 '25 20:06 github-actions[bot]

This issue was automatically closed due to no activity for 6 months plus the 14 day notice period.

github-actions[bot] avatar Jul 11 '25 20:07 github-actions[bot]

@aardappel I can give it a try, but do you have any log/reference to what broke in CI? I was looking around issues/PRs but couldn't find anything.

AdamGS avatar Sep 17 '25 10:09 AdamGS

See https://github.com/google/flatbuffers/pull/8411

aardappel avatar Sep 17 '25 18:09 aardappel

I couldn't find an error message there? but I've opened https://github.com/google/flatbuffers/pull/8700 that also tries to cleanup some of the other rust warnings.

AdamGS avatar Sep 17 '25 19:09 AdamGS