Adam Gutglick comments

Results 27 comments of


                                            Adam Gutglick

Stack overflow when reading file with `ListContainsExpr` filter

meant to edit the comment and lost that tab somewhere 🤦 seems like this is during execution which is obviously an issue, but if we generate these arbitrarily deep trees,...

fix: correctly handle schema evolution in DF

I'll try and review everything on Friday when I'll probably have some time to burn at the airport, but from the description, shouldn't we rely on a fix upstream?

Unify runtime abstractions

Yeah that would be great! I think our IO traits are still changing and having more examples will be good + opendal seems pretty stable so I don't expect it...

Make the `template` proc macro inner name consistent

As for 1, I think it might be because my branch is also named `master`, I'll try and open a second PR with a different branch name. I think at...

Make the `template` proc macro inner name consistent

Seems like changing the branch name did work? #310

Make the `template` proc macro inner name consistent

but closing and opening this PR also seems to work, I'll close #310. Maybe I opened this PR during some github downtime.

Layout readers do not handle projections with repeated columns

I think we should just dedup/fail gracefully right?