datafusion icon indicating copy to clipboard operation
datafusion copied to clipboard

Remove unused feature in `physical-plan` and fix compilation error in benchmark

Open AdamGS opened this issue 5 months ago • 2 comments

Which issue does this PR close?

  • Closes #16448.

Rationale for this change

#15913 introduced a feature to hid a test utilities module in datafusion-physical-plan. The module was later made public but the feature stayed behind making it non-trivial to compile/lint the sort_merge benchmark.

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

AdamGS avatar Jun 18 '25 19:06 AdamGS

The test failure is a fuzzer failure, is there a accepted way to open tickets generated by fuzzing?

AdamGS avatar Jun 18 '25 20:06 AdamGS

The test failure is a fuzzer failure, is there a accepted way to open tickets generated by fuzzing?

I'll restart the test. Maybe you can just create a ticket with a link to the failed run and then the passing one

Here is the failed one

https://github.com/apache/datafusion/actions/runs/15741542523/job/44367876525?pr=16449

alamb avatar Jun 18 '25 21:06 alamb

The test failure is a fuzzer failure, is there a accepted way to open tickets generated by fuzzing?

  • For anyone following along, here is the ticket: https://github.com/apache/datafusion/issues/16452

alamb avatar Jun 19 '25 11:06 alamb