Abdullahi Yunus
Abdullahi Yunus
The project is now complete, and all LN implementations are now supported 💯
Please review @jamaljsr when you have time. Thanks 🙏
Thanks for taking the time to review @kelvinator07! > I've done some manual testing, and all node permutations work well except for the Bob-to-Carol simulation. Please see the logs below...
> Additionally, here are a few suggestions that could improve the feature: >A new simulation should only be added when the network is Started. A new simulation should only be...
review reminder @jamaljsr :)
> > Thanks again for the review, @kelvinator07. All feedback has been addressed. > > Tested ACK! LGTM! Thanks again 🫡
Thanks @jamaljsr for taking a look!. > It looks like we are only allowing 1 simulation. The plus button was disabled after adding the first one. I believe simln supports...
I think it's safe to drop this commit d620eea1e81690ff2f38cd24bb83b9a5cb669e36 since we no longer check for channel before creating a `sim`. I looked into why the container takes a long time...
Thanks @jamaljsr for the review. I have addressed your feedback. > Each activity should have the menu to edit/delete them. We can now delete each activity individually. I considered adding...
> Hey @Abdulkbk. Are you planning on wrapping up this PR. It feels pretty close to done. I'm going to be working on shipping a new release in the next...