Abdullahi Yunus
Abdullahi Yunus
> Thanks for the PR, I think we want things to be more general and not just for the alias. Ie, for any of the fields you can change via...
> Hey @Abdulkbk Thanks for opening the PR. It looks like you're off to a great start. > > My initial feedback just from looking at your screenshots is: >...
This is how it looks now @jamaljsr 
> The UI is looking great now. I left some feedback on the code. Once those changes are made, we just need to have the unit tests updated to prevent...
Nice work @MPins. I left a few comments. Also, I don't think this [commit](https://github.com/lightningnetwork/lnd/pull/8857/commits/31816914381f1002d274a47178c982b22410bafe) is necessary since all you did was add comments.
Hi @MPins thanks for the PR. I've reviewed your work and it seems a new empty line is not added after the log "Shutdown complete" message. It was though before...
@ellemouton, this pull request replaces #8690 as per your suggestion [here](https://github.com/lightningnetwork/lnd/pull/8690/commits/b0815a1fd6bb2e9c2ad450ddf9fef0875b9437a0#r1617278463). Please review when you have time. Thanks
> @Abdulkbk - thanks! Although I think you could have just updated the commits in the original PR - no need for a new PR :) At first, I thought...
Hi @alexbosworth, I've opened this PR to fix the issue #7123 you reported. Could you spare some time to review it? Your input will help me improve the solution.
> Also I think this needs a release note? Maybe add here: https://github.com/lightningnetwork/lnd/blob/7065b6462edf48f3c86a58f2fd215cb0db2c0474/docs/release-notes/release-notes-0.18.1.md Since this PR persists whatever was previously updated with the `updatenodeannouncement` lncli command, it means I should...