Abdullahi Yunus
Abdullahi Yunus
> I think you can add a bullet point to talk about what the change actually is and maybe a short explanation. Maybe under [functional updates](https://github.com/lightningnetwork/lnd/blob/7065b6462edf48f3c86a58f2fd215cb0db2c0474/docs/release-notes/release-notes-0.18.1.md#functional-updates) I just noticed that...
Hi @yyforyongyu , I noticed that you are one of the code owners of [netann](https://github.com/lightningnetwork/lnd/blob/f464dac1cd2f63af4b4e3de4a2c23354acf8db6e/.github/CODEOWNERS-HINT#L144). This PR touches `nodeannouncement`, which I think falls under that. Would you mind reviewing it?...
Could you help approve the CI, @yyforyongyu?
Hey @yyforyongyu, I considered adding a test for this change, but since it involves restarting LND, I'm unsure where to begin. Would you happen to have any pointers? Thank you.
> Restarting a node in the itest can be done in multiple ways, > > > > for instance you can suspend a node and restart it later, > >...
Hmmm can't seem to figure out why the entire itests keep [failing](https://github.com/lightningnetwork/lnd/actions/runs/15401312314/job/43335014417?pr=8825), will need to dig in a little deeper...
> With the following error in Carol's log: > > ``` > unable to create server: can't unset feature bit 25 (route-blinding): feature is used in standard protocol set >...
@saubyk could you add this to the review board?
Tagging @kelvinator07 and @jamaljsr for reviews :)
cc: @kelvinator07 👀