Abdullahi Yunus

Results 7 comments of Abdullahi Yunus

Hi @jamaljsr, I would like to take on this. I'll post updates once I begin.

> Hi @jamaljsr, I would like to take on this. I'll post updates once I begin. I came across this code block: ![Screenshot from 2024-03-01 23-17-30](https://github.com/jamaljsr/polar/assets/45062451/fd032ac3-266a-4e24-920a-1984d7f91ff2) I think it ensures...

> @Abdulkbk yes, Polar will already detect and avoid using ports that are already in use. The situation that @dangeross is describing is that initially Polar assigns LND REST ports...

HI @jamaljsr, I am having a blocker. I worked on a solution for this issue but I noticed that the test failed. My implementation involves leveraging electron's 'before-quit' when a...

> Hey @Abdulkbk, have you tried mocking the `ipcRenderer`'s methods using `jest.fn()`? I've done this before in the [ipcService tests](https://github.com/jamaljsr/polar/blob/master/src/lib/ipc/ipcService.spec.ts#L6). > > Another approach that may work is to use...

I mocked ipcRenderer and it worked @jamaljsr. I've submitted a PR. I'll wait for your review and feedback. Thank you