Aaron ForgeFlow comments

Results 242 comments of


                                            Aaron ForgeFlow

[18.0][MIG] account_operating_unit: Migration to 18.0

I just also did a functional review and LGTM! I will look into the unresolved conflicts issue.

[18.0][MIG] account_operating_unit: Migration to 18.0

@MiquelRForgeFlow I don't understand. What does this image mean?

[18.0][MIG] account_operating_unit: Migration to 18.0

Superseded https://github.com/OCA/operating-unit/pull/772

[18.0][MIG] sale_operating_unit: Migration to 18.0

account_operating_unit is merged. Can you rebase?

[ADD] account_operating_unit: add operating unit in account analytic line

It seems to make sense, I am also wondering if there should be a constraint in the analytic_operating_unit module that prevents analytic lines with different operating unit than the ones...

[18.0][MIG] stock_delivery_note

I think this can be merged

[18.0][MIG] stock_delivery_note

This module is in OCA since v10. The other module was introduced in v15. So in case there are duplicated features I think this one should take over. Maybe in...

[FIX] *_operating_unit: add check_company in field OU

Too bad. It seems OU modules are not multicompany consistent :S The changes are good to me, and I think we should merge this. Multicompany production instances may need to...

[FIX] *_operating_unit: add check_company in field OU

I don't use this in a multicompany environment and I won't be affected. In any case I think it is best to fix the bug in any version.

[FIX] *_operating_unit: add check_company in field OU

I checked and it seems to be already solved in v17. I did not test v16. It is ok to merge it and check if needed in v16