Aaron ForgeFlow

icon company @ForgeFlow

Results 242 comments of Aaron ForgeFlow

[13.0][FIX]account_asset_management: devaluate assets created in locked periods on the first open day

Ok, I will do that, thanks for considering it.

[16.0][FIX] - Set the default date from and date to

why not removing the groups attribute instead?

[16.0][MIG] sale_fully_invoiced: Migration to v16

Thank you for the review. I need to improve the tests for the upselling case. Also fix the module in v15: https://github.com/OCA/sale-workflow/blob/15.0/sale_fully_invoiced/models/sale.py#L29

[16.0][FIX] avoid error in aged partner balance report

It seems to make sense, but this change was added on purpose so maybe you can ping the original authors of that change

[16.0][MIG] account_lock_to_date

/ocabot merge nobump

[16.0][MIG] account_lock_to_date

/ocabot merge nobump

[17.0][MIG] stock_picking_invoicing_incoterm: Migration to 17.0

/ocabot migration stock_picking_invoicing_incoterm

[18.0][MIG] pos_operating_unit: migrate to 18.0

Hi! Thanks for the migration. The commit history is missing. For reference, this is the OCA documentation for migrations: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-18.0

[18.0][MIG] pos_operating_unit: migrate to 18.0

Thank you but it seems there is something not correct. The first commit should not be this: It is strange you have merge conflicts, but in any case there should...

[18.0][MIG] pos_operating_unit: migrate to 18.0

It looks good now. Thank you!