OCA
[18.0][MIG] account_operating_unit: Migration to 18.0
Could you please cherry pick https://github.com/OCA/operating-unit/pull/739 ? It is merged in v15 so for consistency we are adding it in all branches
Could someone kindly address the code coverage issues and merge this pull request? This module is urgently required for our project. Our version upgrade depends on the operating unit functionality, and it is currently on hold due to these issues.
@AaronHForgeFlow, once it's merge i will cherry pick here.
Hi @BhaveshHeliconia, that one is now merged :)
And also those 2 need to be added as well:
- https://github.com/OCA/operating-unit/pull/759
- https://github.com/OCA/operating-unit/pull/761
Thank you.
@AaronHForgeFlow, once it's merge i will cherry pick here.
Hi @BhaveshHeliconia, that one is now merged :)
And also those 2 need to be added as well:
- [FWD][17.0][FIX] account_operating_unit: set OU on exchange move/lines #759
- [17.0][FWD][FIX] account_operating_unit: Inter OU Balance entry several issues #761
Thank you.
@AaronHForgeFlow : Now this PR is ready for review. Thanks.
Could someone kindly address the code coverage issues and merge this pull request? This module is urgently required for our project. Our version upgrade depends on the operating unit functionality, and it is currently on hold due to these issues.
I kindly request that the closing of this PR be expedited.
Hey @OCA/accounting-maintainers when you get a chance, kindly review and consider merging it.
Could someone kindly address the code coverage issues and merge this pull request? This module is urgently required for our project. Our version upgrade depends on the operating unit functionality, and it is currently on hold due to these issues.
@AbhishekkumarReddy : Requested for the review, Hopefully its get reviewed and merge soon.
This PR looks fantastic, let's merge it! Prepared branch 18.0-ocabot-merge-pr-726-by-AaronHForgeFlow-bump-nobump, awaiting test results.
@AaronHForgeFlow The merge process could not be finalized, because command twine check odoo_addon_analytic_operating_unit-18.0.1.0.0.3-py3-none-any.whl failed with output:
Checking odoo_addon_analytic_operating_unit-18.0.1.0.0.3-py3-none-any.whl: [31mFAILED[0m
[31mERROR [0m `long_description` has syntax errors in markup and would not be
rendered on PyPI.
line 76: Warning: Bullet list ends without a blank line; unexpected
unindent.
[33mWARNING [0m `long_description_content_type` missing. defaulting to `text/x-rst`.
I just also did a functional review and LGTM! I will look into the unresolved conflicts issue.
What does this image mean?
It means that when you do a rebase, if there have been changes in the base branch, then all the commits get ordered by the rebase date. But in the image it can be seen that the commit history got divided by your comment, which cannot happen if the rebase is done correctly. It means that some of the commits in this commit history are a wrong in some way.
@AaronHForgeFlow, @MiquelRForgeFlow Due to several history conflicts, I’ve created a new PR here: https://github.com/OCA/operating-unit/pull/772 Could we please close this one and continue the review there?