operating-unit icon indicating copy to clipboard operation
operating-unit copied to clipboard

[FIX] *_operating_unit: add check_company in field OU

Open Saran440 opened this issue 11 months ago • 5 comments

Step to test:

  1. Add multi company and create OU Selection_019

  2. Go to invoice, po, so, exp or else > select Operating Unit field it will show all OU Selection_020

This document created on YourCompany it should select OU that depend on YourCompany only This PR fixed by add check_company=True in header field.

Exclude: line, compute field, wizard (may be it should add too. but I didn't test)

After add it Selection_021

Saran440 avatar Jan 24 '25 10:01 Saran440

Hi @max3903, @ps-tubtim, some modules you are maintaining are being modified, check this out!

OCA-git-bot avatar Jan 24 '25 10:01 OCA-git-bot

Too bad. It seems OU modules are not multicompany consistent :S

The changes are good to me, and I think we should merge this. Multicompany production instances may need to check their data before applying this change. I will wait for other contributors to give their opinion first.

I think having a commit per module is required in OCA, sorry for the pain.

AaronHForgeFlow avatar Jan 24 '25 11:01 AaronHForgeFlow

@AaronHForgeFlow No problem. I think it’s the right thing to do. However, should we start fixing this from version 18?

Because so far, no one has multi ou in multi company.

Saran440 avatar Jan 27 '25 04:01 Saran440

I don't use this in a multicompany environment and I won't be affected. In any case I think it is best to fix the bug in any version.

AaronHForgeFlow avatar Jan 27 '25 07:01 AaronHForgeFlow

I checked and it seems to be already solved in v17. I did not test v16.

It is ok to merge it and check if needed in v16

AaronHForgeFlow avatar Jan 28 '25 09:01 AaronHForgeFlow

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar Jun 01 '25 12:06 github-actions[bot]