AWSHurneyt

Results 64 comments of AWSHurneyt
trafficstars

As mentioned in comment https://github.com/opensearch-project/alerting-dashboards-plugin/pull/471#discussion_r1178241552, the `OPENSEARCH_VERSION` is now redundant, and can be removed.

> @AWSHurneyt Are you the appropriate dev to help me fill in the content gaps for alerting dashboards and visualizations? Integration of alerting and visualizations was part of the feature...

@vagimeli Sorry for the delay! I'll ping you offline with a test domain.

The 2 failing test workflows failed because they use the 2.4 branch of OpenSearch-Dashboards, which is currently on version 2.4.1. The notifications 2.x branch is currently set to 2.4.0, and...

I believe we do have unit tests as well for this plugin? https://github.com/opensearch-project/notifications/tree/main/notifications/notifications/src/test

@amsiglan @sbcd90 could you transfer this to https://github.com/opensearch-project/dashboards-notifications/issues

MacOS CI has been added. https://github.com/opensearch-project/notifications/blob/main/.github/workflows/notifications-test-and-build-workflow.yml#L89 @amsiglan @sbcd90 could you close this issue? I'm not a maintainer.

@amsiglan @sbcd90 could you transfer this issue to https://github.com/opensearch-project/dashboards-notifications/issues Will need to investigate whether this is still an issue.

Hi @tarjei, It looks like the screenshot is cut off just before the message body, so I'm not able to see the sample `ctx` unfortunately. However, here are some links...

@kaituo to clarify, this is the fix, correct? Looks like it's already in the 2.x branch https://github.com/opensearch-project/alerting-dashboards-plugin/commit/b62c1adb5c0797f75dd4a1b414e2026f6a07651e Generated 2.19 backport PR https://github.com/opensearch-project/alerting-dashboards-plugin/pull/1208