Arran Schlosberg
Arran Schlosberg
I've added the interface, @xinbenlv. Please can you take another look?
@axic @g11tech @SamWilsn @xinbenlv I think this has fallen through the cracks. Can we please get a review? I appreciate that some of the delay was due to the repo...
> There is also a `go.testTags` option, but it seems like that doesn't fix the errors presented by the IDE 😞 (although it would fix the running of the tests)...
> Interesting. For mechanical changes like imports or struct modifications this seems like a very promising approach. Might this approach also be appropriate for more complex fork maintenance (i.e. maintaining...
> No argument that the current approach of merging changes without shared history is not ideal, but how would you compare/contrast the AST approach proposed in this PR with maintenance...
@tsachiherman: > I think that I would prefer to have the `config` struct defined in it's own file and leave the `main.go` to be the light-weight entry point for the...
I suspect that `Config` needs to implement [TerminalStringer](https://pkg.go.dev/github.com/ethereum/[email protected]/log#TerminalStringer).
https://github.com/ava-labs/libevm/pull/154 isn't blocked by a Geth sync; it's unblocked by https://github.com/ava-labs/libevm/pull/155 and https://github.com/ava-labs/libevm/pull/156.
> We had discussed this offline, but just to write it down: There is a pretty high probability that we'll need to support all of the labels for compatibility with...
@rjl493456442 I'm gonna leave this in draft as it's only the test demonstration for now; please let me know if you think it's worth addressing.