Arran Schlosberg comments

Repositories
Issues
Comments

Results 24 comments of


                                            Arran Schlosberg

core/state/snapshot: race resulting in `generate()` goroutine leak

> Yes, it's true. We have a dedicated code waiting this event, making sure the test code will be blocked before the generation is finished. Why do you think it's...

uplift `gossip` package from evm repositories

Is this the "temporary" directory, or is it the final destination for this code? If the latter, I'll provide more thorough comments on style.

test: use generated ABI

Please generate them in place to begin with so we can just review directly without depending on something beyond the scope of the PR. Next you can create a trivial...

test: use generated ABI

> ABIs are not a part of Solidity, they're generic. Even though we used Solidity to generate those, the starting point for a stateful precompile starts with the ABI not...