core/types: pin code generators versions when alias types are supported
We use two code generators to generate codec functions for JSON and RLP codecs:
github.com/fjl/gencodecfor JSON - done in #856github.com/ava-labs/libevm/rlp/rlpgenfor RLP (code forked from geth)
The support for type aliases is ongoing as follows:
- https://github.com/fjl/gencodec/pull/25
- https://github.com/ava-labs/libevm/pull/154
- https://github.com/fjl/gencodec/pull/27
Once these are done, we should:
- Upgrade libevm to the version containing this new feature
- (done) Pin fjl/gencodec version to the version containing this new feature, using
tools.go+go mod tidy - (half-done) Add a CI check to ensure these generated files are kept in sync (similar to how it is done with mockgen)
https://github.com/ava-labs/libevm/pull/154 isn't blocked by a Geth sync; it's unblocked by https://github.com/ava-labs/libevm/pull/155 and https://github.com/ava-labs/libevm/pull/156.
Blocked by https://github.com/fjl/gencodec/pull/26
ava-labs/libevm#154 isn't blocked by a Geth sync; it's unblocked by ava-labs/libevm#155 and ava-labs/libevm#156.
Awesome! 💯 Should we then do another libevm release soon-ish so I can incorporate this in our coreth libevm branch? 🤔