Arran Schlosberg

Results 24 comments of Arran Schlosberg

@gballet and @MariusVanDerWijden can you please take a look when you get a chance? I've also sent over #25055 but if you've only got time for one review, please focus...

Hey @MariusVanDerWijden, not a problem re the delay, this is low priority :) thanks for the feedback. What would your suggested approach look like for `SendTransaction()`? Would it copy the...

@MariusVanDerWijden I've opted to simplify the entire process by just exposing the flag struct that was previously unexported, reverting all of the `Option`s. Please can you take another look?

> Wouldn't it be simpler to just copy the config on every call? Why should that be optional? That would be ideal, but it introduces a breaking change into an...

Thanks @holiman. Just to confirm that we weren't talking about different things, I meant a `type backends.SimulatedBackendConfig` (or more succinct name) that has a `New()`. Do you mean the same,...

> we could just clobber them as NewSimulatedBackendWithDatabaseAndConfig, or do the more elegant variadic options-route. I could probably accept either, not sure what other people prefer @MariusVanDerWijden originally felt the...

In case it helps others, I found that it only worked when adding the local strategy into my VS settings: ``` "go.toolsEnvVars": { "GOPACKAGESDRIVER": "${workspaceFolder}/devtools/gopackagesdriver.sh", "GOPACKAGESDRIVER_BAZEL_BUILD_FLAGS": "--strategy=GoStdlibList=local", }, ```

> We discussed that we like the big long clunky constructor **better** than the variadic methods. So just adding `NewSimulatedBackendWithDBAndConfig` should do the trick. We can worry about smarter approaches...

I'm experiencing something similar and the only commonality I can find between the failing packages is that they use generics. This may very well be a red herring, and I...

> Hi, the interface in specification section has not been finished, can you finish them before you turn this PR for merge again? Shall do. Once done I'll tag you...