Castro

Castro copied to clipboard

adopt a code of conduct

1

We should adopt a code of conduct for our project. I adapted the Astropy code of conduct (which is CC licensed). My intention is for this code of conduct to...

zingale

## PR summary Instead of using the Jacobian transformation of variables, we update the conserved state and then just use ConsToPrim() ## PR motivation ## PR checklist - [ ]...

zingale

## PR summary ## PR motivation ## PR checklist - [ ] test suite needs to be run on this PR - [ ] this PR will change answers in...

zingale

Replace monopole gravity with Poisson gravity?

2

Even though in principle Poisson gravity can be used in the places where we currently use monopole gravity, we use monopole gravity only in 1D spherical coordinates (and can use...

maxpkatz

Geometry source terms should be traced

4

In trace_ppm.cpp, the geometric source terms are added to the states with a mysterious `eta` factor that depends on the Courant number. We should instead include the geometric source terms...

zingale

Sometimes we use eos_input_re instead of eos_input_rt, but it is not clear if that is always needed. If the temperature has already be set, then can be used. For example,...

zingale

We should consider implementing the Blondin & Lukfin interpolants: https://ui.adsabs.harvard.edu/abs/1993ApJS...88..589B/abstract

zingale

## PR summary This implements the reference state in the characteristic project a la Colella 1990 or Stone et al. 2008. ## PR motivation ## PR checklist - [ ]...

zingale

Should we remove update_sources_after_reflux?

1

`update_sources_after_reflux` re-evaluates all source terms after a reflux on all levels. The logic is that the distribution of matter on the grid has changed, so the new-time source terms we...

maxpkatz

AMR with MHD

1

This issue will keep track of any remaining tasks with using AMR with the MHD solver

zingale