Castro

Castro copied to clipboard

slipwall and noslipwall are the same

2

The implementation of the slipwall and noslipwall boundaries in `Castro_setup.cpp` appear to be identical. noslipwall should force the transverse velocity to 0.

zingale

castro.update_sources_after_reflux doesn't make sense for MOL/new SDC

4

The `castro.update_sources_after_reflux` functionality uses the "new" source stuff, and does the corrector after the flux correction. But for MOL (and new SDC) integration, we don't ever use the new source...

zingale

switch CTU to conservative diffusion

3

Currently we treat diffusion as an external source and compute the old-time diffusion from `S_old`, use this in the predictor, and then compute the new-time diffusion after the conservative update,...

zingale

radiation should use _cpp_parameters

7

To make it easier to discover, document, and add runtime parameters, we should modify `Gravity.cpp`, `Radiation.cpp`, and `Diffusion.cpp` to use the `_cpp_parameters` functionality.

zingale

add support for non-square cells

3

Atleast for pure hydro problems, it would be useful to support rectangular cells. In particular, for the XRB problems. This should mostly be a case of making sure the correct...

zingale

output where and why the timestep limit is set

4

We should have an option to print out where in the domain is the most restrictive timestep and what limiter is the cause (hydro, diffusion, reaction, ...)

zingale

get rid of grav_source_type < 4

1

The older gravity source types are really not as good. Certainly types 1 and 3 aren't ever used. `grav_source_type = 2` might be useful for comparison purposes, but also could...

zingale

The Poisson solve absolute tolerance sets the accuracy of the Poisson solve. Given the value of abs_tol, the error level targeted in the Poisson solve is abs_tol * 4 *...

maxpkatz

When on the GPU, we don't want to print, so we need to have a logging system that we can send messages to (in Fortran-land) and cache them, then output...

zingale

radiation hyperbolic BCs need to know about flux BCs

1

When we a radiation flux entering through a boundary into a vacuum state, the boundary conditions on the radiation energy in the hyperbolic part need to know about this. There...

zingale