Castro

Castro copied to clipboard

consider removing reference states from eigenvectors

1

Currently, in the ppm tracing, we use the reference states in computing the eigenvectors. But this means that, since we include sources now in the reference states, that all the...

zingale

We should merge the 2 ppm tracing routines, as most of the code is redundant.

zingale

Sometimes we only model a portion of a star, with the surface outside of the computational domain. We used to have the ability to spherically average the star on the...

zingale

Switch to key = value format for _prob_params

1

The _prob_params script (and perhaps later on _cpp_parameters and the extern variables) should be switched to a key = value format so that we can more easily add fields in...

maxpkatz

Right now, if the interface prediction for density is > `small_dens`, we set the interface state to density. But this will yield a thermodynamically inconsistent state. A better approach might...

zingale

true SDC detonation tests are failing

1

We have 2 true SDC detonation tests in the test suite (one 2nd order and the other 4th order). Currently, they have VODE errors after 12 - 14 timestep. This...

zingale

make finest level dx() known at probinit time

4

For generating initial models at runtime, it would be useful to know already when we call `probinit` what the finest level `dx(:)` is. One way we could do this is...

zingale

## PR summary ## PR motivation ## PR checklist - [ ] test suite needs to be run on this PR - [ ] this PR will change answers in...

zingale

implement the CMA method

5

## PR summary This does a better(?) implementation of the CMA method. By working on the interface states directly, it will be in effect for the transverse flux differences and...

zingale

consider computing geometry on demand via inlined functions

1

Right now we carry around 3 area MFs + 1 volume MF. These are not used very widely, and it seems that with the C++ conversion, we could create an...

zingale