Castro icon indicating copy to clipboard operation
Castro copied to clipboard

Geometry source terms should be traced

Open zingale opened this issue 4 years ago • 4 comments

In trace_ppm.cpp, the geometric source terms are added to the states with a mysterious eta factor that depends on the Courant number. We should instead include the geometric source terms into the characteristic tracing, as in the original PPM paper.

zingale avatar Mar 08 '20 00:03 zingale

In particular, it looks like we are using the PLM tracing for PPM

zingale avatar Mar 21 '20 00:03 zingale

Here's a derivation of the geometric sources terms for the primitive system we solve euler_geometric_source_terms.pdf

zingale avatar Mar 21 '20 21:03 zingale

One idea was to simply add these in src_to_prim, but the problem there is that these sources depend on the direction of the reconstruction. When we are doing the tracing in x (r), the sources are present, but they are not present in any of the other tracing directions. This directional dependence doesn't exist for any of the other primitive sources.

zingale avatar Apr 12 '20 18:04 zingale

I think that the cleanest way to do this is to create a function add_geometry_sources() that is called in trace_ppm.cpp when we are doing the reconstruction of the other source terms. This will depend on idir and we will need to explicitly set do_trace for these components to be true.

zingale avatar May 30 '23 17:05 zingale