ADmad

Results 347 comments of ADmad

- Test(s) required for the change. - The `primaryKey` config should be added to `$_defaultConfig` of all actions that use the `FindMethodTrait::_findRecord()` method. - Docs need to be updated to...

`ModelAwareTrait` (which provide `loadModel()`) has been deprecated since Cake 4.3 and dropped in 5.0. So there's no point in making change for this now for a deprecated feature.

> I don't see any non deprecated way. There isn't any. Webservice plugin and Crud support for it will have to be re-thought for working without the deprecated features. If...

Why do need to use `CrudComponent::table()`? You can directly use `$this->loadModel()` in your controller. Within the plugin `CrudComponent::table()` is only used by `CrudComponent::entity()` which isn't used anywhere in the plugin...

Since you need to use `loadModel()` one way or the other just keeping using that even for tables. 5.x is a different story. Will have to see how to update...

Yes, would you like to submit a PR for the `cake-5` branch?

How/why is `city_id` an `int`? Passed values normally come request query string which are always strings.

If we are going to widen the type then let's just make it `mixed` instead of limiting to scalars and array. This value is eventually going to be used in...

@kolorafa Can you try out the `issue-65` branch an report back please.

Merge conflict needs to be fixed :(