Steve Muir

Just a process point: this PR is 'on top' of the original Sprint 1 PR #33, do you intend to close the original one and instead have us focus our...

I stumbled across this too a couple of weeks ago but got distracted. I can't remember if I had a fix, let me dig through my code

I see, it's probably the circular `load_module` calls, and the fact that `client/fabfile.py` resets `env.gsmenv`unconditionally. The loading of `client/fabfile.py` from common should probably be conditional upon it not already having...

Doesn't @kheimerl have access to the endaga.com repo? I think he and @shaddi are the repo maintainers.

Given that this is structured as 144 commits it would be possible to go back and create a number of smaller patches, but I understand that doing so would be...

PLEASE address the comments I made by adding new commits to this PR rather than creating a whole new PR. If you create a new PR it's impossible to track...

Thanks for addressing my comments. A couple of high-level comments from @kkroo: - please use the 'guardian' Django extension to handle permission checking: https://django-guardian.readthedocs.io/en/stable/api/guardian.templatetags.guardian_tags.html - remove any debug/test code that...

Thanks for the updates, will take a look. As discussed on the weekly call, we can't merge them until the changes to use Guardian have been made. One process point:...

Per my comment on #45, please consider closing this PR and making all subsequent changes there. We aren't going to merge these changes until the Guardian integration is complete.

Please address comments from our internal linter:  If you rebase against the current head then three of the F401 errors should go away (I fixed them in a commit...