CommunityCellularManager
CommunityCellularManager copied to clipboard
facebookarchive
Guardian permissions
Guardian Permission Implementation. This commit is on top of sprint_1 (user management and subscriber management).
Also: Added user management where user wasn't able to see any same level user to block/unblock or delete. Added Role in subscriber management.
Please review Thanks
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!
If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact [email protected] if you have any questions.
Just a process point: this PR is 'on top' of the original Sprint 1 PR #33, do you intend to close the original one and instead have us focus our attention on this one, or address them separately? At this point I recommend the former, as we don't want to merge the permission changes without Guardian incorporated.
Once you have addressed @kkroo's comments we can review this again. Just one additional minor request that will eliminate numerous lint errors that get flagged by our internal build system: please make sure EVERY file ends with a newline, but that the last line of the file does not contain any other whitespace. And remove any code that is currently commented out.
Thanks
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!
Hello,
Please review 3ed0bf7 on top of this with all changes incorporated and added redesign which includes
This include:
Add/Edit/Block/Delete User Assign permission on multiple networks Guardian permissions Attached are the snapshots for user management
this commit is on top of this pr ( #45 ) closing #75 as this commit is same.
@kkroo has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.