CommunityCellularManager icon indicating copy to clipboard operation
CommunityCellularManager copied to clipboard

Network balance limit (Client dependent)

Open shivkumarsah opened this issue 7 years ago • 15 comments

Please review network/subscriber credit limit implementation which include the below features:

  • Cloud admin and admin have rights to set the highest denomination bracket (Reload limit) correspond to which subscriber can do top up.
  • Cloud admin and admin have rights to set the maximum balance limit a subscriber can have. Retailer cannot transfer more than the set balance limit amount to any subscriber.
  • Subscribers can not have the account balance greater than the set balance limit.
  • Cloud admin and admin have rights to set the limit on maximum number of consecutive unsuccessful transactions.

shivkumarsah avatar Jun 02 '17 14:06 shivkumarsah

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact [email protected] if you have any questions.

facebook-github-bot avatar Jun 02 '17 14:06 facebook-github-bot

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

facebook-github-bot avatar Jun 02 '17 14:06 facebook-github-bot

@shivkumarsah updated the pull request - view changes

facebook-github-bot avatar Jun 02 '17 15:06 facebook-github-bot

Careful to split out reviews. I think this also contained #39

kkroo avatar Jun 05 '17 16:06 kkroo

@shivkumarsah updated the pull request - view changes

facebook-github-bot avatar Jun 08 '17 17:06 facebook-github-bot

@shivkumarsah updated the pull request - view changes

facebook-github-bot avatar Jun 08 '17 17:06 facebook-github-bot

@shivkumarsah updated the pull request - view changes

facebook-github-bot avatar Jun 13 '17 06:06 facebook-github-bot

is this ready for review?

kkroo avatar Jun 15 '17 02:06 kkroo

yes , please review.As suggested comments are incorporated.

piyushabad88 avatar Jun 15 '17 04:06 piyushabad88

@shivkumarsah updated the pull request - view changes

facebook-github-bot avatar Jun 29 '17 10:06 facebook-github-bot

@shivkumarsah updated the pull request - view changes

facebook-github-bot avatar Jun 29 '17 11:06 facebook-github-bot

@9muir has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot avatar Jul 19 '17 21:07 facebook-github-bot

Please address comments from our internal linter:

image

If you rebase against the current head then three of the F401 errors should go away (I fixed them in a commit recently).

9muir avatar Jul 19 '17 21:07 9muir

@shivkumarsah updated the pull request - view changes - changes since last import

facebook-github-bot avatar Jul 21 '17 09:07 facebook-github-bot

@9muir has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot avatar Jul 21 '17 13:07 facebook-github-bot