Manpreet Singh

Results 9 comments of Manpreet Singh

This is a back-up PR. I am working on the fix right now. paasta had been pinned to lower version to unblock users at the moment. Will push this only...

> lgtm, although it might be worth chatting with #security real fast to make sure this isn't going to do something silly with the sensitive env vars that the previous...

* Add description, ticket-id, test-plan and test-runs

lgtm overall. Address remaining comments. Resolve the comments which have been addressed. For first change, I would go for executor count as `0, 16`. Roll it out only once we...

Code looks ok to me. Can you add unit-tests and few manual tests in the relevant ticket?

Can you add description, testing, any impact on existing infra, rollout and rollback plan if needed?

Please manually test most common cases before pushing. Preferable to push after EST morning timezone.

`--mrjob` option integration is missing. It needs to be added as part of list TronConfig

Change lgtm. I would suggest to run some manual test cases (adhoc spark runs) before pushing this. Seems like it's not blocking. Would suggest to push on Monday.