paasta icon indicating copy to clipboard operation
paasta copied to clipboard

MLCOMPUTE-967 | add default iam role for Spark drivers on k8s

Open CaptainSame opened this issue 1 year ago • 5 comments

  • Add newly created iam role to system paasta configs
  • Add methods to fetch the iam role
  • Use the iam role for creating the service account to start the Spark drivers with
  • Mount kubeconfig file to Spark driver pods
  • Point to the mounted kubeconfig using env variable

CaptainSame avatar Aug 17 '23 13:08 CaptainSame

Can you add description, testing, any impact on existing infra, rollout and rollback plan if needed?

88manpreet avatar Aug 23 '23 18:08 88manpreet

The Spark ui port is currently picked from system_paasta_confg with a default value of 33000.

=> It should be picked by a pre-defined port range from spark_constants in srv-configs. Which the ranged is currently used by our Jupyter spark metrics aggregator.


EDIT:

  1. The logic above is included in service_configuration_lib.get_spark_conf(), which should also be called by the spark driver on k8s implementation (might need to be slightly modified).

  2. Some other logic such as _parse_user_spark_args(), where the executor pod template (to set dnsPolicy) is assigned, also need to be called by the driver on k8s implementation.

edingroot avatar Jan 24 '24 16:01 edingroot

Cherry-picked https://github.com/Yelp/paasta/pull/3749

edingroot avatar Jan 29 '24 16:01 edingroot

Please manually test most common cases before pushing. Preferable to push after EST morning timezone.

88manpreet avatar Feb 16 '24 15:02 88manpreet

We'll need to upgrade service_configuration_lib to the latest version which includes https://github.com/Yelp/service_configuration_lib/pull/139

edingroot avatar Feb 16 '24 15:02 edingroot

--mrjob option integration is missing. It needs to be added as part of list TronConfig

88manpreet avatar Mar 05 '24 15:03 88manpreet