Nick Pillitteri
Nick Pillitteri
This seems to be an increase in scope from the original intent of this feature: > this will help Agent team determine if a feature is getting enough traction to...
> Maybe having a configuration check somewhere at startup? Good idea. Could also be part of some kind of a "generate troubleshooting information" tool / command.
> Is this related? #552 Yep, related but not exactly the same AFAICT. #552 downloads multiple blocks in parallel while the change referenced here would download each file that is...
> I would like to first learn which Mimir component would benefit from it. The compactor is currently the only component that calls the Thanos `block.Download()` method which is where...
> Any plans for `mimirtool` to support loki ? Not in mimirtool, no. Loki team is evaluating creating a dedicated tool but that's something they'll have to prioritize (or not).
> I think we should merge this change only after it has been dogfooded at Grafana Labs (aka: running in all prod envs). We're used to change defaults only after...
As a requirement for implementing this, I'd need to see as part of the PR: * Documentation about exactly what pieces of information would be collected and an example payload...
Could a requirement of this feature please be documenting how the information collected will evolve over time, if at all? I ask because we're asking our OSS users to trust...
> what do yall think about headers the distributor returns when the sample is deduplicated? That might show the detected cluster label value and the currently elected replica? Very interesting...
> A few questions: > > 1. the util package previously didn't import anything from within mimir, but now it has to as it needs globalerrors at least. it also...